commit 1d4df42c96c0fbdafb83be956efc435da54ef112 Author: Opensource Date: Tue Apr 16 18:14:05 2019 -0400 Remove unused Identity implicit imports (#13573) I ran `git grep --files-with-matches "import io.fsq.common.scala.Identity._" -- *.scala | xargs grep -L "=?\|optionally\|flatOptionally\|ifOption\|applyIf\|applyOpt\|withMinOf\|withMaxOf\|between" | xargs sed -i '' '/import io.fsq.common.scala.Identity._/d'` to remove the import from files where implicit was not being used. I then ran `find . -name *-repl.scala | xargs git checkout f55298543750c7e4c08ae3c6c3c5c7a210679cef -- ` to revert the various service repl startup scripts, so that they could keep the import. (sapling split of cab9f3950cf8baf70467bce41f2216dd12aa7067) src/jvm/io/fsq/common/concurrent/FutureOutcome.scala | 1 - 1 file changed, 1 deletion(-) commit 8cfc835755fc31c5233d59e92ea6e9f763c44dce Author: Opensource Date: Mon Apr 15 20:09:33 2019 -0400 Remove unneeded Lists.scala implicits imports (#13478) `git grep --files-with-matches "import io.fsq.common.scala.Lists" | xargs grep -L "swap\|partitionInPlace\|removeAll\|removeAllBy\|aggregate\|product\|productReverse\|powerset\|powerset\|nth\|sequence1\|sequence2\|map12\|map1\|map1\|unfold\|shuffled\|shuffledDeterministically\|sample\|toListBy\|flatToListBy\|toVectorBy\|flatToVectorBy\|toArrayBy\|flatToArrayBy\|toSetBy\|toMapBy\|toMutableMapBy\|flatToSetBy\|flatToMapBy\|toMapByKey\|flatToMapByKey\|topNSorted\|mkJoin\|has\|flatGroupBy\|mapAccum\|flatMapAccum\|distinctBy\|flatDistinctBy\|countDistinctBy\|distinctCounts\|minByOption\|minOption\|maxOption\|maxByOption\|collectFirstOpt\|tailOption\|groupWhile\|crowd\|histogramBy\|partitionN\|chunkMap\|slidingPairs\|chunkFlatMap\|filterOutWith\|groupByKeyValueSet\|toMapAccumValueSet\|groupByKeyValue\|toMapAccumValues\|topNUnsorted\|topNSorted\|topNPartition\|flatMapFind\|exactlyOne\|hasOverlap\|zipOption\|zipLeftOption\|zipRightOption\|yankToIndex\|indexWhereOption\|indexOfOption\|nth\|pth\|sortByDesc\|sortedDesc\|insertAfter\|hasKey\|invert\|flattenValues\|mappedValues\|flatMapValues\|isEmptyOr\|unzipped\|flatCollect\|toVectorBy\|flatToVectorBy\|Rand\|sumBy\|slidingOptPairs" | xargs sed -i '' '/import.*Lists.Implicits/d'` (sapling split of 06c0771b48844a64a1ae1c6dc771be109ea032b4) src/jvm/io/fsq/common/concurrent/FutureOutcome.scala | 1 - 1 file changed, 1 deletion(-) commit 57e82c5bf9f962a5204ccea07b398632341959ad Author: Ian Tabolt Date: Thu Feb 7 12:24:52 2019 -0800 Finagle upgrade 6.39.0 take 3 - fix Kestrel deserialization issue (#11338) * Revert "Revert "Upgrade Finagle to 6.39.0 - take 2 (#11013)" (#11068)" * Add kestrel round trip test and fix Shared/Owned bytebuffer bug (sapling split of 0e5da761ddc15e7c5cc59c9ceab56bbf1f3d5d7e) src/jvm/io/fsq/common/concurrent/Futures.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4aa6650f859c8e3087dcbbf46171775a1a0deead Author: Ian Tabolt Date: Fri Jun 15 17:56:01 2018 -0400 Scalafmt EVERYTHING (#6987) * Run scalafmt on everything * Flip the switch to enable scalafmt (FSQ_ENABLE_SCALAFMT=True) * Add some // format: off and // format: on comments in particularly weird cases * Disable scalafmt on files that cause exceptions (sapling split of 61c9ef3975aa4f55f70e479d7908f42de0685d26) (sapling split of 8264ffd5eb789041b44688c92b468f426833730e) .../io/fsq/common/concurrent/FutureOption.scala | 64 +++--- .../io/fsq/common/concurrent/FutureOutcome.scala | 35 ++-- src/jvm/io/fsq/common/concurrent/Futures.scala | 216 +++++++++++---------- src/jvm/io/fsq/common/concurrent/PoolJumper.scala | 32 +-- src/jvm/io/fsq/common/concurrent/StableVar.scala | 9 +- 5 files changed, 188 insertions(+), 168 deletions(-)